Add random method to Unitary.#707
Merged
Aubaert merged 3 commits intoQuandela:release/1.2.0from Jan 21, 2026
Merged
Conversation
Aubaert
reviewed
Jan 14, 2026
| return f"Unitary({', '.join(params)})" | ||
|
|
||
| @staticmethod | ||
| def random(m: int) -> "Unitary": |
Contributor
There was a problem hiding this comment.
You can avoid setting the returned value in quotes by adding from __future__ import annotations at the beginning of this file
Contributor
Author
There was a problem hiding this comment.
Thanks @Aubaert.
My first commit did this, but it still failed the auto-test.
What do you think?
Contributor
There was a problem hiding this comment.
Ok I think it's because we removed this from __future__ import annotations in the release branch. In that case, can you add this comment after this line?
# Python 3.11 : Replace using Self typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To generate random unitaries in Perceval, one has to do the following:
Matrix.random_unitaryis almost always used to create a randomUnitaryobject. So, for conciseness I have added arandomstatic method toUnitarythat callsMatrix.random_unitary.